Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device: Use OwnedFd type and bump MSRV to 1.66 #75

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

device: Use OwnedFd type and bump MSRV to 1.66 #75

wants to merge 2 commits into from

Commits on Oct 14, 2023

  1. device: Use OwnedFd type and bump MSRV to 1.66 

    The first new commit 22a2365 on `next` switches to the `RawFd` type from
the `std::os::fd` module which is only available since Rust 1.66.  This
module also provides an `OwnedFd` type which already has a `close()`
call in the `Drop` implementation, and implements the desired `AsRawFd`
(and `AsFd` and `IntoRawFd`) traits.

Note that these types were already stabilized in Rust 1.63 under
`std::os::unix::io`, which is now merely a reexport of `std::os::fd`.

This also replaces the forgotten `.fd()` calls with `.as_raw_fd()` from
from commit 17c2871.
    @MarijnS95
    MarijnS95 committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    bd7762c View commit details
    Browse the repository at this point in the history

  2. Use size_of_val on slices for binary size

    @MarijnS95
    MarijnS95 committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    e7a90c5 View commit details
    Browse the repository at this point in the history