Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor sdk issues #336

Merged
merged 7 commits into from
Sep 14, 2023
Merged

fix: minor sdk issues #336

merged 7 commits into from
Sep 14, 2023

Conversation

rsbh
Copy link
Member

@rsbh rsbh commented Sep 14, 2023 •
edited
Loading

Changes:

  1. Show domain name instead of hardcoded placeholder.
  2. Fix Table pagination
  3. Add loader screen in add member modal. disable button if fields are not valid

@rsbh rsbh requested a review from pyadav September 14, 2023 09:18
@vercel
Copy link

vercel bot commented Sep 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 10:38am

@rsbh rsbh marked this pull request as ready for review September 14, 2023 10:38
@pyadav pyadav merged commit 62e1384 into main Sep 14, 2023
10 checks passed
@pyadav pyadav deleted the fix_minor_sdk_issues branch September 14, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyadav pyadav pyadav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsbh @pyadav