Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): remove admin apis #341

Merged
merged 5 commits into from
Sep 18, 2023
Merged

fix(sdk): remove admin apis #341

merged 5 commits into from
Sep 18, 2023

Conversation

rsbh
Copy link
Member

@rsbh rsbh commented Sep 15, 2023 •
edited
Loading

Changes:

  1. Fix close button redirect
  2. Remove admin apis from sdk
  3. Update JS client with latest proto
  4. Replace service calls as per latest JS client

@vercel
Copy link

vercel bot commented Sep 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ❌ Failed (Inspect) Sep 18, 2023 5:33am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6218257065

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.713%
Totals Coverage Status
Change from base Build 6211381114: 0.0%
Covered Lines: 6078
Relevant Lines: 11985
💛 - Coveralls

@rsbh rsbh requested a review from pyadav September 18, 2023 05:35
@rsbh rsbh marked this pull request as ready for review September 18, 2023 05:35
@rsbh rsbh changed the title fix: minor sdk UI issues fix(sdk): remove admin apis Sep 18, 2023
@pyadav pyadav merged commit 27476ca into main Sep 18, 2023
9 of 10 checks passed
@pyadav pyadav deleted the fix_minor_sdk_ui_issues branch September 18, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyadav pyadav pyadav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsbh @coveralls @pyadav