Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide domain action is user doesnt have create persmission #349

Merged
merged 8 commits into from
Sep 21, 2023
Merged

fix: hide domain action is user doesnt have create persmission #349

merged 8 commits into from
Sep 21, 2023

Conversation

rsbh
Copy link
Member

@rsbh rsbh commented Sep 20, 2023 •
edited
Loading

Changes

  1. Hide delete domain and verify domain if user doesn't have access to create domain (org manage).
  2. Add back button to project and team page. the back button will navigate to listing page.
  3. Fix Preferences spelling typo. Perferences -> Preferences
  4. Disable org name (slug) text field as it is not user cant update org name.

@vercel
Copy link

vercel bot commented Sep 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 5:56pm

@rsbh rsbh marked this pull request as ready for review September 20, 2023 10:31
@rsbh rsbh requested a review from pyadav September 20, 2023 10:31
@coveralls
Copy link

coveralls commented Sep 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6252303287

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.462%
Totals Coverage Status
Change from base Build 6252247533: 0.0%
Covered Lines: 6066
Relevant Lines: 12021
💛 - Coveralls

@rsbh rsbh force-pushed the fix_domain_table_auth_check branch from eb72d08 to 7590f67 Compare September 20, 2023 17:55
@pyadav pyadav merged commit 533747d into main Sep 21, 2023
9 checks passed
@pyadav pyadav deleted the fix_domain_table_auth_check branch September 21, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyadav pyadav pyadav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsbh @coveralls @pyadav