-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PO-120 (Opencart<> Opencart Deprecated error) #165
Conversation
.idea/.gitignore
Outdated
@@ -0,0 +1,8 @@ | |||
# Default ignored files | |||
/shelf/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitcbr what are these three files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashgit891 not sure of these files when pushing, should these 3 files be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitcbr if they are not part of sdk update and also not made by you then ideally it should not be present.
@@ -112,7 +112,7 @@ | |||
$_['text_invoice'] = 'Invoice Details'; | |||
$_['text_not_select_sub_ID'] = 'Please Select Subscription '; | |||
$_['text_subscription_status'] = 'Enable Subscription in Settings.'; | |||
$_['text_webhook_cron_header'] = 'Set the cron job in your WHMCS site server to call the Cron URL in every 5 mins frequncy.'; | |||
$_['text_webhook_cron_header'] = 'Set the cron job in your opencart site server to call the Cron URL in every 5 mins frequncy.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitcbr please put platform as OpenCart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashgit891 updated here
$_['text_webhook_cron_header'] = 'Set the cron job in your OpenCart site server to call the Cron URL in every 5 mins frequncy.'; |
@@ -0,0 +1,39 @@ | |||
name: feature.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitcbr Please remove .github folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashgit891 removed in this commit 94244e8
@@ -0,0 +1,34 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitcbr please remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashgit891 removed in this commit 94244e8
@@ -0,0 +1,14 @@ | |||
# This file is for unifying the coding style for different editors and IDEs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitcbr please remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashgit891 removed in this commit 94244e8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note :- Please follow the below points while attaching test cases document link below:
- If label
Tested
is added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.