Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PO-120 (Opencart<> Opencart Deprecated error) #165

Merged
merged 6 commits into from
May 20, 2024

Conversation

rohitcbr
Copy link
Contributor

Note :- Please follow the below points while attaching test cases document link below:

- If label Tested is added then test cases document URL is mandatory.

- Link added should be a valid URL and accessible throughout the org.

- If the branch name contains hotfix / revert by default the BVT workflow check will pass.

Test Case Document URL
Please paste test case document link here....

@rohitcbr rohitcbr requested review from ramth05 and yashgit891 May 15, 2024 09:34
rohitcbr added 3 commits May 15, 2024 17:36
1. used razorpay-php sdk 2.9.0
2. updated code for compatibility in "catalog/controller/extension/payment/razorpay.php"
3. fixed a minor bug in "admin/language/en-gb/extension/payment/razorpay.php"
.idea/.gitignore Outdated
@@ -0,0 +1,8 @@
# Default ignored files
/shelf/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitcbr what are these three files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashgit891 not sure of these files when pushing, should these 3 files be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitcbr if they are not part of sdk update and also not made by you then ideally it should not be present.

@@ -112,7 +112,7 @@
$_['text_invoice'] = 'Invoice Details';
$_['text_not_select_sub_ID'] = 'Please Select Subscription ';
$_['text_subscription_status'] = 'Enable Subscription in Settings.';
$_['text_webhook_cron_header'] = 'Set the cron job in your WHMCS site server to call the Cron URL in every 5 mins frequncy.';
$_['text_webhook_cron_header'] = 'Set the cron job in your opencart site server to call the Cron URL in every 5 mins frequncy.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitcbr please put platform as OpenCart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashgit891 updated here

$_['text_webhook_cron_header'] = 'Set the cron job in your OpenCart site server to call the Cron URL in every 5 mins frequncy.';

@@ -0,0 +1,39 @@
name: feature.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitcbr Please remove .github folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashgit891 removed in this commit 94244e8

@@ -0,0 +1,34 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitcbr please remove this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashgit891 removed in this commit 94244e8

@@ -0,0 +1,14 @@
# This file is for unifying the coding style for different editors and IDEs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitcbr please remove this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashgit891 removed in this commit 94244e8

Copy link
Contributor

@yashgit891 yashgit891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitcbr rohitcbr marked this pull request as ready for review May 20, 2024 10:47
@rohitcbr rohitcbr added the TestingNotRequired TestingNotRequired label for BVT label May 20, 2024
@rohitcbr rohitcbr merged commit 620766c into master-opencart3 May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants