Bug fix #66
Open
Bug fix #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramth05
reviewed
Jan 27, 2022
|
|
||
| public function uninstall() { | ||
|
|
||
| $result = $this->db->query("SHOW COLUMNS FROM " . DB_PREFIX . "order LIKE 'webhook_flag'"); |
There was a problem hiding this comment.
move DB changes it inside model
ramth05
reviewed
Jan 27, 2022
| @@ -212,7 +211,15 @@ protected function orderPaid(array $data) | |||
| $merchant_order_id = $data['payload']['payment']['entity']['notes']['opencart_order_id']; | |||
| $razorpay_payment_id = $data['payload']['payment']['entity']['id']; | |||
| if(isset($merchant_order_id) === true) | |||
| { | |||
| { | |||
| $this->load->model('extension/payment/razorpay'); | |||
There was a problem hiding this comment.
check if this can be loaded one time only in class.
There was a problem hiding this comment.
@ramth05 have checked for this, tried using class instance but it not working out.
ramth05
reviewed
Jan 27, 2022
|
|
||
| public function setWebhookFlag($order_id,$flag) { | ||
|
|
||
| $this->db->query("UPDATE " . DB_PREFIX . "order SET webhook_flag = '" . (int)$flag . "' WHERE order_id = '" . (int)$order_id . "'"); |
There was a problem hiding this comment.
As this table if belongs to opencart, rename the column to razorpay_webhook_count
ramth05
reviewed
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.