Migrate to OCamlMakefile, fix file corruption issue, support Mac OS X build. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
pkg-mp3packerto build a binary for Ubuntu 14.04, but the result was corrupting mp3 files (they still appeared to be valid files, but on playback something was obviously wrong).I had changes locally I'd done to get mp3packer working on on Mac OS X (including replacing the custom
makefilewithOCamlMakefile). At the time I had tried to abstract all the options for byte swapping in a pair of functions. With minor changes I was able to get that building on Ubuntu and producing identical files the Mac OS X build.I did my best to apply a minimal patch, since I had a number of changes similar to one you already had. I did my best to correctly work with the debian packing in
pkg-mp3packer(although I could not getgit-buildpackageto generate a changelog).