-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support windows targets #11
Conversation
@rdelfin Any update? |
oh! Really sorry, didn't see your PR! I'll take a look and prepare a release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to do this!
#[cfg(windows)] | ||
junction::create(output_path, symlink_path).map_err(Error::SymlinkCreationFailure)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the they're trying to add support on the standard library, but it's still nightly :/
rust-lang/rust#121709
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I have a requirement to run on rust 1.77 so I couldn't do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah absolutely, I don't want to turn this into a nightly-only crate
Fixing clippy error in #12 |
@carlocorradini: I can prepare a release, but before I do so, can you confirm latest main now works for you? If not, I can dig into why |
@rdelfin It works! Thanks! 🥳 |
Glad to @carlocorradini. Check this project's crates.io and you should see a new version (0.2.1) with windows support |
Tested on windows 10 and windows 11.
EDIT: It seems there is something else within the extraction that relies on windows symlinks directly which is an issue for non-admin users: