Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the build instructions in README #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hean01-cendio
Copy link
Contributor

@hean01-cendio hean01-cendio commented Nov 1, 2017

The recently added instruction to README is a bit shorthanded when it comes to building SeamlessRDP for 64bit platform. This PR is the first take to explain how to do so.

cd seamlessrdp-1.0
./configure
make
You need to have both mingw32 and mingw64 installed to be able to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Fedora, you want mingw32-gcc and mingw64-gcc installed. You then run mingw32-configure or mingw64-configure instead of ./configure, then make as usual. You don't have to bother with knowing the host triplets for 32- and 64-bit environments.

On Ubuntu, installing mingw-w64 will get the cross-compiler for both 32 and 64-bit applications set up properly. The host triplet on Ubuntu is i686-w64-mingw32 and x86_64-w64-mingw32, and the regular build instructions are OK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better if we tell our users the specific packages they need (on a few select distros) rather than the generalized info that might not be helpful enough for some.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Fedora, you want mingw32-gcc and mingw64-gcc installed. You then run mingw32-configure or mingw64-configure instead of ./configure, then make as usual. You don't have to bother with knowing the host triplets for 32- and 64-bit environments.

It works perfectly fine to run ./configure --host= on fedora so with that in mind, these instruction does not differs from whenever you are on ubuntu or fedora. Only the way how to get the two compilers installed, which we do not mention and care about.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I still think there's value in describing how to set up the cross-compiling environment, but we can leave that for a wiki page or something.

@derfian
Copy link
Member

derfian commented Nov 1, 2017

All things considered, I think this is an improvement over the existing README.

@githubkoma
Copy link

Please merge this, as only this PR helped me to find the missing piece for Cross-Compiling......

@bradcarnage
Copy link

thread bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants