Skip to content

Commit

Permalink
[Actions] Fixing the documentation preview not displaying due to a mi…
Browse files Browse the repository at this point in the history
…ssing PR number (#1744)

* Make sure the pr number file is not treated as a hidden file

* Make sure the pr number file name is properly allignt in the deployment workflow
  • Loading branch information
VeithMetro authored Sep 11, 2024
1 parent 996d561 commit 71899bf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/Build Documentation Preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
python-version: 3.x
- run: pip install mkdocs-material
- run: mkdocs build
- run: echo "${{ github.event.number }}" >> ./site/.pr_number
- run: echo "${{ github.event.number }}" >> ./site/pr_number
- name : Upload preview site artifact
uses : actions/upload-artifact@v4
with:
Expand All @@ -42,7 +42,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- run: mkdir pr_tmp
- run: echo "${{ github.event.number }}" >> ./pr_tmp/.pr_number
- run: echo "${{ github.event.number }}" >> ./pr_tmp/pr_number
- uses : actions/upload-artifact@v4
with:
name: closed_pr_number
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/Deploy Documentation Preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ jobs:
# Get PR number
- if: ${{ env.mode == 'deploy' }}
name: Get PR number (deploy)
run: echo "pr_number=$(cat ./artifacts/preview_site/.pr_number)" >> "$GITHUB_ENV"
run: echo "pr_number=$(cat ./artifacts/preview_site/pr_number)" >> "$GITHUB_ENV"

- if: ${{ env.mode == 'clean' }}
name: Get PR number (clean)
run: echo "pr_number=$(cat ./artifacts/closed_pr_number/.pr_number)" >> "$GITHUB_ENV"
run: echo "pr_number=$(cat ./artifacts/closed_pr_number/pr_number)" >> "$GITHUB_ENV"

# Run deployment
- if: ${{ env.mode == 'deploy' }}
Expand Down

0 comments on commit 71899bf

Please sign in to comment.