TEST COVERITY. DO NOT MERGE #1826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity Issue - Logically dead codeExecution cannot reach this statement: "buffer[index] = c;". Medium Impact, CWE-561 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Logically dead codeExecution cannot reach this statement: "buffer[index] = '\0';". Medium Impact, CWE-561 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
| @@ -546,7 +546,8 @@ namespace Core { | |||
| char buffer[bufferSize]; | |||
| while (true) { | |||
| char c; | |||
| size_t readChars = fread(&c, 1, 1, cmdFile); | |||
| size_t readChars = 0; | |||
| fread(&c, 1, 1, cmdFile); | |||
There was a problem hiding this comment.
Coverity Issue - Ignoring number of bytes read
"fread(void *, size_t, size_t, FILE *)" returns the number of bytes read, but it is ignored.
Medium Impact, CWE-252
CHECKED_RETURN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.