ES1-631 - TTS thunder interface change #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: TTS plugin to support callsign based registeration Test Procedure: Mentioned in ticket Risks: Low Signed-off-by: vdinak240 <[email protected]>
pwielders
approved these changes
Feb 26, 2024
pwielders
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
This looks like redundant functionality as by default, the IShell interface (part of every plugin) allows for QueryInterfaceByCallsign, so I think it is superfluous and unnecessary but as I am not the component owner of the implementation of this plugin I will approve. @karuna2git / @anand-ky to validate the usefulness of this method!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: TTS plugin to support callsign based registeration
Test Procedure: Mentioned in ticket
Risks: Low