-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template_smiles.h #10
Conversation
CRDGEN-98 CRDGEN-103
@ZontaNicola, instead of updating the header directly, would you mind moving your changes to the There's instructions here: https://github.com/rdkit/molecular_templates#how-to-contribute |
whoops thanks! |
Talked this through with @cdvonbargen and got DDAG's approval on the structures I suggested. @rachelnwalker @ricrogz is there anything else that I need to do here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You are good Nic. I just merged your PR. This will trigger the CI and update the header & stuff in a couple of minutes. |
Thank you @ZontaNicola! |
CRDGEN-98 CRDGEN-103