Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template_smiles.h #10

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Update template_smiles.h #10

merged 4 commits into from
Nov 27, 2023

Conversation

ZontaNicola
Copy link
Contributor

CRDGEN-98 CRDGEN-103

CRDGEN-98 CRDGEN-103
@ricrogz
Copy link
Collaborator

ricrogz commented Nov 16, 2023

@ZontaNicola, instead of updating the header directly, would you mind moving your changes to the templates.smi, so that the automated checks can run on them?

There's instructions here: https://github.com/rdkit/molecular_templates#how-to-contribute

@ZontaNicola
Copy link
Contributor Author

whoops thanks!

@ZontaNicola ZontaNicola reopened this Nov 16, 2023
Copy link

#73 C1CC2C3CCC4C1C1CCC2C2CCC1C1CCC2C3CCC41#74 C1C2C3CC4C5CC3C1C5C24

Copy link

#73 C1CC2C3CCC4C1C1CCC2C2CCC1C1CCC2C3CCC41#74 C1C2C3CC4C5CC3C1C5C24

@cdvonbargen
Copy link
Collaborator

cdvonbargen commented Nov 16, 2023

would it be possible to make the coordinates more 3d-like the suggested templates in those cases? my assumption is that we're taking cues from cubane's 3d-like structure? or do we not want that?

Screenshot 2023-11-16 at 1 45 27 PM Screenshot 2023-11-16 at 1 45 09 PM

@ZontaNicola
Copy link
Contributor Author

Talked this through with @cdvonbargen and got DDAG's approval on the structures I suggested. @rachelnwalker @ricrogz is there anything else that I need to do here?

Copy link
Collaborator

@ricrogz ricrogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricrogz ricrogz merged commit f8e2ce0 into rdkit:main Nov 27, 2023
1 check passed
@ricrogz
Copy link
Collaborator

ricrogz commented Nov 27, 2023

Talked this through with @cdvonbargen and got DDAG's approval on the structures I suggested. @rachelnwalker @ricrogz is there anything else that I need to do here?

You are good Nic. I just merged your PR. This will trigger the CI and update the header & stuff in a couple of minutes.

@rachelnwalker
Copy link
Collaborator

Thank you @ZontaNicola!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants