Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer dependency for React 18 in combobox package #980

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

drDre-code
Copy link

Hey guys, right now if you install this package with a fresh React 18 project, you get a ERESOLVE unable to resolve dependency tree and I made this small change so that not everyone needs to do the whole --legacy-peer-deps thing.

Hey team, right now if you install this package with a fresh React 18 project, you get a ERESOLVE unable to resolve dependency tree and I made this small change so that not everyone needs to do the whole --legacy-peer-deps thing.
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

⚠️ No Changeset found

Latest commit: efbf0a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drDre-code drDre-code marked this pull request as draft October 17, 2022 15:07
@drDre-code drDre-code marked this pull request as ready for review October 17, 2022 15:07
@ben-heimberg
Copy link

is it gonna happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants