Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for contentClass prop #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stan-sack
Copy link

@stan-sack stan-sack commented Sep 28, 2020

Background

  • I've recently run into some issues with the content component where I am unable to set overflow: visible on the div and an absolute div inside is getting cut off. I need to be able to pass a className to the content container, it doesnt work to just set the style on the main Panel div.

Changes

  • Add support for contentClass prop

Tests

  • Existing unit tests pass
  • Verified that the feature works in my own project by building and importing the newly built Panel

@vercel
Copy link

vercel bot commented Sep 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/collapse/nasta7l59
✅ Preview: https://collapse-git-fork-stan-sack-stancontentclass.react-component.vercel.app

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files           5        5           
  Lines         117      117           
  Branches       35       35           
=======================================
  Hits          114      114           
  Misses          3        3           
Impacted Files Coverage Δ
src/Panel.tsx 95.83% <ø> (ø)
src/PanelContent.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d62a6...817041e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant