Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more accessibility data #101

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: Add more accessibility data #101

wants to merge 1 commit into from

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 20, 2020

看了一下,当年 Menu 基于 Lighthouse 打分做了一下 aria 标签,但是并没有真的连起来。找个时间两个组件一同整理一下。

ref react-component/menu#137

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #101 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   98.57%   98.70%   +0.12%     
==========================================
  Files           2        2              
  Lines          70       77       +7     
  Branches       24       24              
==========================================
+ Hits           69       76       +7     
  Misses          1        1              
Impacted Files Coverage Δ
src/Dropdown.tsx 98.64% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c415b...d86972d. Read the comment docs.

@afc163
Copy link
Member

afc163 commented May 20, 2020

https://github.com/ant-design/ant-design/runs/691739740

https://github.com/ant-design/ant-design/suites/698853523/artifacts/6703648

lighthourse 里针对 a11y 也有很多扣分项,可以一并解决一下。

image

@afc163
Copy link
Member

afc163 commented Apr 15, 2023

冲突了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants