fix(Dropdown): renderChildren use mergedVisible for calculation #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
给一下问题本身。 |
最简单的一个fail case，就是受控展开时没有rc-dropdown-open的className
下面是正常的展开状态
|
|
#179 这个Issue也是同样的问题 |
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 2 2
Lines 68 68
Branches 22 22
=======================================
Hits 67 67
Misses 1 1
Continue to review full report at Codecov.
|
afc163
reviewed
Jan 20, 2022
| @@ -138,7 +138,7 @@ function Dropdown(props: DropdownProps, ref) { | |||
| const { children } = props; | |||
| const childrenProps = children.props ? children.props : {}; | |||
| const childClassName = classNames(childrenProps.className, getOpenClassName()); | |||
| return triggerVisible && children | |||
| return mergedVisible && children | |||
|
lint的要fix吗？是以前遗留的代码 |
一起修了吧 |
ousiri
force-pushed
the
fix-mergedVisible
branch
from
a23c76f
to
347045c
Compare
都修好了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renderChildren使用triggerVisible导致受控时上下层组件状态不一致。此处改为mergedVisible