-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prop chart to include prefixCls #601
Open
SebastianKurp
wants to merge
1
commit into
react-component:master
Choose a base branch
from
SebastianKurp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems not to be the only one missing from the README.md. If you look at the src/Slider.tsx Lines 7 to 47 in b5a337e
The docs do not match with the interface very well or am I missing somehing? Maybe there should be a seperate issue and fix all at once. And here it seems that the defaults set can be seen from src/common/createSlider.tsx slider/src/common/createSlider.tsx Lines 16 to 46 in b5a337e
|
Rebase please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Noticed that
prefixCls
is a prop that is exposed, but not documented. So I added it to the props chart in the readMe.Here's an example code snippet of it in use, with a screenshot of the HTML to show that it is passing in the
prefixCls
to the className.