fix: gracefully handle null items (#517)

* gracefully handle null files * add test --------- Co-authored-by: Ian Baer <[email protected]>
react-component · Sep 21, 2023 · a729bcc · a729bcc
1 parent f78cca9
commit a729bcc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/traverseFileTree.ts b/src/traverseFileTree.ts
@@ -36,6 +36,9 @@ function loopFiles(item: InternalDataTransferItem, callback) {
 const traverseFileTree = (files: InternalDataTransferItem[], callback, isAccepted) => {
   // eslint-disable-next-line @typescript-eslint/naming-convention
   const _traverseFileTree = (item: InternalDataTransferItem, path?: string) => {
+    if (!item) {
+      return;
+    }
     // eslint-disable-next-line no-param-reassign
     item.path = path || '';
     if (item.isFile) {

diff --git a/tests/uploader.spec.js b/tests/uploader.spec.js
@@ -395,6 +395,22 @@ describe('uploader', () => {
       }, 100);
     });
 
+    it('dragging and dropping a non file with a file does not prevent the file from being uploaded', done => {
+      const input = uploader.find('input').first();
+      const file = {
+        name: 'success.png',
+      };
+      input.simulate('drop', {
+        dataTransfer: { items: [{ webkitGetAsEntry: () => null }, makeDataTransferItem(file)] },
+      });
+      const mockStart = jest.fn();
+      handlers.onStart = mockStart;
+      setTimeout(() => {
+        expect(mockStart.mock.calls.length).toBe(1);
+        done();
+      }, 100);
+    });
+
     it('unaccepted type files to upload will not trigger onStart when select directory', done => {
       const input = uploader.find('input').first();
       const files = [