Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: File upload components can still select files in the Safari browser #516

Closed
wants to merge 4 commits into from

Conversation

xiaozisong
Copy link

@xiaozisong xiaozisong commented Sep 5, 2023

File upload components can still select files in the Safari browser

fix ant-design/ant-design#44170

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
upload ❌ Failed (Inspect) Sep 6, 2023 2:21am

@yoyo837
Copy link
Member

yoyo837 commented Sep 5, 2023

修复的具体问题描述一下?或者提供复现在antd创建一个issue?

@xiaozisong
Copy link
Author

修复的具体问题描述一下?或者提供复现在antd创建一个issue?

好的!

@xiaozisong
Copy link
Author

xiaozisong commented Sep 5, 2023

修复的具体问题描述一下?或者提供复现在antd创建一个issue?

antd的issue编号 ant-design/ant-design#44170

src/AjaxUploader.tsx Outdated Show resolved Hide resolved
src/AjaxUploader.tsx Outdated Show resolved Hide resolved
src/AjaxUploader.tsx Outdated Show resolved Hide resolved
src/AjaxUploader.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #516 (1f9292d) into master (f78cca9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1f9292d differs from pull request most recent head 413a7dd. Consider uploading reports for the commit 413a7dd to get more accurate results

@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files           6        6           
  Lines         252      252           
  Branches       63       63           
=======================================
  Hits          214      214           
  Misses         38       38           
Files Changed Coverage Δ
src/AjaxUploader.tsx 82.44% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ
Copy link
Member

zombieJ commented Sep 21, 2023

在这里先记录一下,和 Collaborator 讨论了一下,这个 PR 不太敢合。因为如果浏览器更新了行为,把不包含文件也过滤掉,这个很可能会 break。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants