Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Fix Android build #65

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix Android build #65

wants to merge 7 commits into from

Conversation

jlkalberer
Copy link

@jlkalberer jlkalberer commented May 27, 2020 •
edited
Loading

Summary

Fixing the issues outlined in #64

  • Updated to new version of React and fixed Android build errors
  • Updated iOS podfile to build/test iOS
  • Upgraded yarn.lock

Test Plan

Ran the example project on iOS and Android
Screen Shot 2020-12-03 at 8 28 39 AM

What's required for testing (prerequisites)?

  1. Clone the repo
  2. run yarn android

What are the steps to reproduce (after prerequisites)?

Verify that the example no longer crashes

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator
  • [X ] I added the documentation in README.md
  • [???] I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • [X ] I added a sample use of the API in the example project (example/App.js)

@jlkalberer
Fix Android build
8ce7ec5 
Upgrade yarn.lock
Upgrade RN to 0.62.2
@jlkalberer jlkalberer mentioned this pull request May 27, 2020
Open
@Clonescody
Copy link

Hi guys, when can we expect this to be merged ? I need this fix in my app.

Thanks !

@Clonescody
Copy link

@EvanBacon Sorry to bother you, but could you check this PR really quick ?
I feel like this issue is impacting a lot of other librairies, and I need it tbh :D

Thanks !

@jlkalberer
Copy link
Author

Yeah, it's weird that they don't fix it themselves or approve this pull request :/

@jlkalberer jlkalberer mentioned this pull request Sep 23, 2020
Open
layne and others added 3 commits November 9, 2020 16:23
fix(ios): Xcode12 build run on device crash (react-native-art#70)
b71f5f4 
Since the ARTShadow structure holds a color object, it will cause a zombie object after destruction.
@dependabot
Bump lodash from 4.17.15 to 4.17.19 (react-native-art#67)
cc5f058 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump acorn from 5.7.3 to 5.7.4 (react-native-art#58)
7499855 
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.3...5.7.4)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Esemesek
Copy link
Collaborator

Esemesek commented Nov 9, 2020

Hey, thanks for the PR. Everything looks good, but it seems that I cannot push to your master branch to fix conflicts. I'll merge this PR when conflicts will be resolved.

@n0490b
Copy link

n0490b commented Nov 13, 2020

@jlkalberer Any ETA on fixing the merge conflicts? Thanks

@jlkalberer
Copy link
Author

@jlkalberer Any ETA on fixing the merge conflicts? Thanks

I’m away from a computer until next week. I’m glad this issue is finally getting traction but this PR has been out forever...

@jlkalberer
Copy link
Author

I'll have a fix for this today with iOS testing.
Be ready to merge :D

@jlkalberer
Copy link
Author

I rebased my changes on top of this branch and have tested things again. I've updated the original PR with the new test plan.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nmvictor nmvictor nmvictor approved these changes

@iyogeshjoshi iyogeshjoshi iyogeshjoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jlkalberer @Clonescody @Esemesek @n0490b @nmvictor @iyogeshjoshi