Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Add repository info to package.json #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add repository info to package.json #69

wants to merge 2 commits into from

Conversation

mrousavy
Copy link

@mrousavy mrousavy commented Sep 4, 2020

Summary

This adds the repository property to the package.json.

One problem with having no repository property is, that tools like license crawlers cannot read the creator and add repository links.

See how the author is ??? and the View Repository button is not present?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

Copy link
Collaborator

@Esemesek Esemesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not really true anymore since we moved to a new organization. Can we update the url?

@mrousavy
Copy link
Author

mrousavy commented Nov 9, 2020

@Esemesek I assume we don't want to change the package name, right?

@Esemesek
Copy link
Collaborator

Esemesek commented Nov 9, 2020

Yup, the package name stays the same for now.

"author": "@react-native-community",
"homepage": "https://github.com/react-native-community/react-native-art",
"author": "react-native-art",
"homepage": "https://github.com/react-native-art/react-native-art",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/react-native-art/art C:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants