Skip to content

Commit

Permalink
Merge pull request #172 from devnev/no-java-options-env
Browse files Browse the repository at this point in the history
fix: remove _JAVA_OPTIONS parameter & environment

BREAKING CHANGE: The java_options parameter has been removed. Specify your JVM options in the gradle.properties file or in the gradle_options with -Dorg.gradle.jvmargs= instead.
  • Loading branch information
fotos authored May 23, 2024
2 parents faee857 + d737af9 commit a7d373e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions src/executors/linux_android.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
parameters:
java_options:
description: Java command options. Note that setting this will override the default options so you might need to supply those as well.
type: string
default: '-Xmx1024m -XX:+UnlockExperimentalVMOptions -XX:+UseContainerSupport'
gradle_options:
description: Gradle command options. Note that setting this will override the default options so you might need to supply those as well.
type: string
Expand All @@ -19,5 +15,4 @@ docker:
- image: reactnativecommunity/react-native-android:<<parameters.build_image_version>>
resource_class: <<parameters.resource_class>>
environment:
- _JAVA_OPTIONS: <<parameters.java_options>>
- GRADLE_OPTS: <<parameters.gradle_options>>
5 changes: 0 additions & 5 deletions src/jobs/android_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ parameters:
description: Configure the android tests to run. Defaults to assembleAndroidTest
type: string
default: assembleAndroidTest
java_options:
description: Java command options. Note that setting this will override the default options so you might need to supply those as well.
type: string
default: '-Xmx1024m -XX:+UnlockExperimentalVMOptions -XX:+UseContainerSupport'
gradle_options:
description: Gradle command options. Note that setting this will override the default options so you might need to supply those as well.
type: string
Expand All @@ -66,7 +62,6 @@ parameters:

executor:
name: linux_android
java_options: <<parameters.java_options>>
gradle_options: <<parameters.gradle_options>>
build_image_version: <<parameters.build_image_version>>
resource_class: <<parameters.resource_class>>
Expand Down

0 comments on commit a7d373e

Please sign in to comment.