-
Notifications
You must be signed in to change notification settings - Fork 445
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #83 from react-native-webrtc/release_v3
Prepare v3 release
- Loading branch information
Showing
7 changed files
with
84 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,12 @@ | ||
CallKeep is a fork of react-native-callkit by ianlin. | ||
Since it only target iOS devices, we created CallKeep to target both Android and iOS. | ||
Since react-native-callkit only targets iOS devices, we created react-native-callkeep to target both Android and iOS. | ||
|
||
Ian Yu-Hsun Lin <[email protected]> | ||
Wazo Communication inc. <[email protected]> | ||
Dan Jenkins <[email protected]> | ||
Kyle Kurz <[email protected]> | ||
bhuangy <[email protected]> | ||
Chevon Christie | ||
Linus Unnebäck <[email protected]> | ||
Geraint White <[email protected]> | ||
Samuel Bégin |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
# Migration from CallKeep v2 to v3 | ||
|
||
Thanks to the Sangoma team, CallKeep now allows multi calls through native UI. | ||
Here's how to upgrade your codebase for this new version. | ||
|
||
## Common | ||
|
||
### setup | ||
|
||
Since the v3, you have to call `setup` each time your application is launched. | ||
|
||
### didPerformDTMFAction | ||
|
||
`didPerformDTMFAction` now take `digits` instead of `dtmf` as key of its argument. | ||
|
||
### didPerformSetMutedCallAction | ||
|
||
`didPerformSetMutedCallAction` now returns an object as argument with `{ muted, callUUID }`. | ||
|
||
### startCall | ||
|
||
`startCall` takes 3 arguments now : `uuid`, `handle`, `contactIdentifier`. | ||
|
||
### Call uuids | ||
|
||
`setCurrentCallActive`, `endCall`, now takes a `callUuid` argument. | ||
|
||
Events are also with an `callUUID` in the argument object. | ||
|
||
### ⚠️ Lower case your uuids | ||
|
||
There is no more check on the uuid case, everything is returned to your application in lower case. | ||
So you have to send lower cased uuid to allow matching your calls. | ||
|
||
### News methods | ||
|
||
There is now new method like [updateDisplay]() | ||
|
||
## Android | ||
|
||
### Update `MainActivity.java` | ||
|
||
- Add new imports | ||
|
||
```diff | ||
+ import android.support.annotation.NonNull; | ||
+ import android.support.annotation.Nullable; | ||
``` | ||
|
||
- Update `onRequestPermissionsResult` method: | ||
|
||
```java | ||
// Permission results | ||
@Override | ||
public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) { | ||
super.onRequestPermissionsResult(requestCode, permissions, grantResults); | ||
switch (requestCode) { | ||
case RNCallKeepModule.REQUEST_READ_PHONE_STATE: | ||
RNCallKeepModule.onRequestPermissionsResult(requestCode, permissions, grantResults); | ||
break; | ||
} | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,20 +6,16 @@ | |
"scripts": {}, | ||
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/wazo-pbx/react-native-callkeep.git" | ||
"url": "git+https://github.com/react-native-webrtc/react-native-callkeep.git" | ||
}, | ||
"author": "Wazo (http://wazo.io)", | ||
"maintainers": [ | ||
"Wazo Team <[email protected]> (https://github.com/wazo-pbx)" | ||
], | ||
"contributors": [ | ||
"Wazo Team <[email protected]> (https://github.com/wazo-pbx)" | ||
], | ||
"author": "See AUTHORS file", | ||
"maintainers": ["See AUTHORS file"], | ||
"contributors": ["See AUTHORS file"], | ||
"license": "ISC", | ||
"bugs": { | ||
"url": "https://github.com/wazo-pbx/react-native-callkeep/issues" | ||
"url": "https://github.com/react-native-webrtc/react-native-callkeep/issues" | ||
}, | ||
"homepage": "https://github.com/wazo-pbx/react-native-callkeep#readme", | ||
"homepage": "https://github.com/react-native-webrtc/react-native-callkeep#readme", | ||
"typings": "./index.d.ts", | ||
"peerDependencies": { | ||
"react-native": ">=0.40.0" | ||
|