Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to change the tick interval + added hours, seconds etc as a div that can hidden or shown #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

salmankhann
Copy link

No description provided.

@svnm
Copy link
Member

svnm commented Apr 11, 2017

Hey @salmankhann thanks for your work on this. Unfortunately I would need to change a few things in this pr, so it might be best to discuss your ideas for enhancing it, and plan a few of the enhancements.

  • We would prefer to have the component be less reliant on dom nodes so it works well with rendering to string serversider. So using dangerouslySetInnerHTML would not be a good idea.

  • I think the tick interval needs to be 1000 for this to work correctly as a count down? We might need to do some more research on the math, it has been awhile since I set this up.

Thanks, Steven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants