Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node version to 18 #835

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Upgrade node version to 18 #835

wants to merge 2 commits into from

Conversation

sujithvn
Copy link

@sujithvn sujithvn commented Mar 2, 2023

Resolves #6396
Impact: major
Type: feature|chore

Issue

Reaction API is being upgraded to Node18. Make the same upgrade for Storefront

Solution

Updated the Node version in Dockerfile to node:18.10.0-alpine
Node 18 has conflict in crypto/hash [error:0308010C:digital envelope routines::unsupported]. The solution/workaround is to use NODE_OPTIONS=--openssl-legacy-provider

We have introduced additional commands/scripts in package.json which includes the above mentioned NODE_OPTION as command line parameter. Use the command scripts with :latest

Note
We have not added assertion for import json as that is handled by webpack (json-loader)

Breaking changes

Old versions Node 14/15 no longer supported

Testing

All automated tests should pass
Complete full order placement using Node18 both in Storefront and API

@sujithvn
Copy link
Author

Note
We have not added assertion for import json as that is handled by webpack (json-loader)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants