Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature generic classes #143

Merged
merged 20 commits into from
Sep 26, 2022
Merged

Feature generic classes #143

merged 20 commits into from
Sep 26, 2022

Conversation

nilsauf
Copy link
Contributor

@nilsauf nilsauf commented Sep 15, 2022

Hi,

this PR enables the generator to generate code for generic classes, fixing #117 in the process. It also handels type constraints.
I had to change a few things, but the rest should work as expected. Take your time to review it.

Feel free to contact me for any questions.

@nilsauf
Copy link
Contributor Author

nilsauf commented Sep 26, 2022

@glennawatson any thoughts on this?

@glennawatson glennawatson merged commit 71eb227 into reactivemarbles:main Sep 26, 2022
@glennawatson
Copy link
Member

Thanks for the reminder. This one slipped through the cracks. Thanks again

@nilsauf nilsauf deleted the generics branch September 26, 2022 20:51
@nilsauf
Copy link
Contributor Author

nilsauf commented Sep 27, 2022

Is it possible to deploy a release from the main branch?

@glennawatson
Copy link
Member

@nilsauf
Copy link
Contributor Author

nilsauf commented Sep 27, 2022

Tanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants