Upgrade AWS SDK to 2.20.138 reproduce & and fix #65

reactiverse · Aug 31, 2023 · 6ced644 · 6ced644
1 parent 5a86371
commit 6ced644
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -1,5 +1,5 @@
 val vertxVersion = "4.4.5"
-val awsSdkVersion = "2.20.74"
+val awsSdkVersion = "2.20.138"
 val junit5Version = "5.8.2"
 val logbackVersion = "1.2.10"
 val localstackVersion = "0.2.22"
@@ -37,7 +37,7 @@ repositories {
 }
 
 fun isNonStable(version: String): Boolean {
-  val stableKeyword = listOf("RELEASE", "FINAL", "GA").any { version.toUpperCase().contains(it) }
+  val stableKeyword = listOf("RELEASE", "FINAL", "GA").any { version.uppercase().contains(it) }
   val regex = "^[0-9,.v-]+(-r)?$".toRegex()
   val isStable = stableKeyword || regex.matches(version)
   return isStable.not()

diff --git a/gradle.properties b/gradle.properties
@@ -0,0 +1 @@
+org.gradle.jvmargs=-Xmx4096m
diff --git a/src/main/java/io/reactiverse/awssdk/reactivestreams/WriteStreamSubscriber.java b/src/main/java/io/reactiverse/awssdk/reactivestreams/WriteStreamSubscriber.java
@@ -36,7 +36,7 @@ public void onSubscribe(Subscription subscription) {
 
     @Override
     public void onNext(ByteBuffer byteBuffer) {
-        if (byteBuffer.array().length != 0) {
+        if (byteBuffer.hasRemaining()) {
             Buffer buffer = Buffer.buffer(Unpooled.wrappedBuffer(byteBuffer));
             stream.write(buffer);
         }