Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version > 2.20.75 of aws-sdk will in some cases not function with the reactiverse client #65

Closed
mikand13 opened this issue Aug 30, 2023 · 6 comments
Assignees
Labels
bug Something isn't working version upgrade Upgrading versions (Vert.x / AWS SDK)
Milestone

Comments

@mikand13
Copy link

In my case it concerns the S3 SDK.

L39 of WriteStreamSubscriber.java crashes when calling byteBuffer.array() because the S3 SDK passes a bytebuffer that is backed by an array but is read-only.

From docs:

ReadOnlyBufferException - If this buffer is backed by an array but is read-only

This prevents us from upgrading beyong 2.20.75

@aesteve
Copy link
Collaborator

aesteve commented Sep 1, 2023

Thanks a lot for reporting this ahead of time for the migration, this helped a lot.

I was able to reproduce in #66 and published a snapshot version here: https://oss.sonatype.org/content/repositories/snapshots/io/reactiverse/aws-sdk/1.2.2-SNAPSHOT/

Would you potentially have time to try this version locally and see if this fixes everything for you (and doesn't introduce any regression, too).

Thanks again!

@aesteve aesteve self-assigned this Sep 1, 2023
@aesteve aesteve added bug Something isn't working version upgrade Upgrading versions (Vert.x / AWS SDK) labels Sep 1, 2023
@aesteve aesteve added this to the 1.2.2 milestone Sep 1, 2023
@mikand13
Copy link
Author

mikand13 commented Sep 1, 2023

Can do 👌

@aesteve
Copy link
Collaborator

aesteve commented Sep 8, 2023

Hello,

I'm not exactly sure how long snapshots are available for on Nexus (I think it might be 30 days?) but in case the link above becomes unavailable please ping me.

Let me know if your tests are running fine so that I can release 1.2.2.

Thank you.

@mikand13
Copy link
Author

mikand13 commented Sep 8, 2023

Yeah, sorry. I'm on it, but im away from work atm. We're testing it in an underlying lib now which will go into mainline in the near future bar any issues. Seems to work fine so far, just wanted to verify with the code that experienced the issue.

@mikand13
Copy link
Author

mikand13 commented Sep 9, 2023

Seems to work just fint @aesteve . Any timeline for 1.2.2?

@aesteve
Copy link
Collaborator

aesteve commented Sep 11, 2023

You should be good now: https://central.sonatype.com/artifact/io.reactiverse/aws-sdk/versions

Ping me if it's not the case!
Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version upgrade Upgrading versions (Vert.x / AWS SDK)
Projects
None yet
Development

No branches or pull requests

2 participants