Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Make Bind() ViewModel parameters nullable. #2468

Merged
merged 6 commits into from
Jul 31, 2020
Merged

Fix: Make Bind() ViewModel parameters nullable. #2468

merged 6 commits into from
Jul 31, 2020

Commits on Jul 30, 2020

  1. Removed unused viewmodel parameter on ExecuteHook 

    ViewModel objects are passed in mainly to help enforce generic typing without the user needing to manually type in all the generics themselves.  Being passed to this internal functionality as object seems unnecessary
    @Noggog
    Noggog committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    237817d View commit details
    Browse the repository at this point in the history

  2. Bind mixins viewmodel parameter made nullable 

    The parameter is mainly there to simplify generic specification for the calling user.  Therefore, it doesn't matter if it is null.  Making the parameter nullable means it lines up cleaner with ReactiveControl's ViewModel member, which is 99% of the time what is being passed in.
    @Noggog
    Noggog committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    1ff631d View commit details
    Browse the repository at this point in the history

  3. Revert "Removed unused viewmodel parameter on ExecuteHook" 

    This reverts commit 237817d.
    @Noggog
    Noggog committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    41bb83f View commit details
    Browse the repository at this point in the history

  4. Tied up loose ends with the commit reversal

    @Noggog
    Noggog committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    f9170cf View commit details
    Browse the repository at this point in the history

  5. Removed ArgumentNullExceptions. Offset /w some nullable params

    @Noggog
    Noggog committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    1319854 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Modified API agreement text files

    @Noggog
    Noggog committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    816e798 View commit details
    Browse the repository at this point in the history