-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-395: Add Dependabot support to the project #396
Conversation
Fixes: reactor#395 Issue link: reactor#395 * Added `dependabot.yml` config for both `main` and `1.3.x` supported branches * Include updates of `package-ecosystem` for Gradle and GitHub Actions * Extract `development-dependencies` group for those dependencies which are used only for this project development: all the test dependencies, `compileOnly` and Gradle plugins Note: had to rename label in project repository to the `type: dependency-upgrade` and also added `type: task`
If that is the right direction, I have a reusable GHA workflow like |
@artembilan This configuration will create duplicate PRs for branch In Reactor we have an agreement that labels do not contain
You will need to exclude some versions for certain dependencies e.g. https://github.com/reactor/reactor-pool/blob/main/.github/dependabot.yml |
Does this perform forward merge as all Reactor projects does forward merge starting from the oldest maintenance branch to the main? If yes go for it. |
Right. Sorry for my ignorance. I didn't think that other projects may follow different merge approach. If that does not work for you, I'll definitely will provide config only for the Will rename labels shortly. I don't believe that we need so many ignores, if our schema is like this:
So, Dependabot would not look even into a new minor version. |
yeah a long time ago ... :) we discussed what merge strategy we want to support so we decided to adopt |
This is generally ok although for example for junit we update the minor version, but that's up to you. |
…d merge` strategy * Exclude `com.google.code.findbugs:jsr305` from possible updates * Rename labels to `type/dependency-upgrade` and `type/task`
From our experience it is better to do such an update in a new our minor version or do that manually to be sure that nothing is broken. Since you are looking for |
Thank you for review, @violetagg ! What is rule, please? Do I merge PR myself? Might be subsequent changes when Dependabot runs. |
yes, the one that opened the PR, merges it and does the forward merge (this is for the committers not contributors)
If it is something trivial, a direct commit is ok, but typically we use PRs. PRs are must for bugs/features. When we release the project the release notes are generated based on the PRs. |
Fixes: #395
Issue link: #395
dependabot.yml
config for bothmain
and1.3.x
supported branchespackage-ecosystem
for Gradle and GitHub Actionsdevelopment-dependencies
group for those dependencies which are used only for this project development: all the test dependencies,compileOnly
and Gradle pluginsNote: had to rename label in project repository to the
type: dependency-upgrade
and also addedtype: task