Skip to content

Commit

Permalink
Update test suite to avoid unhandled promise rejections
Browse files Browse the repository at this point in the history
  • Loading branch information
clue committed Jul 6, 2023
1 parent b9641ac commit 9a3d930
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
8 changes: 7 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"require": {
"php": ">=8.1",
"react/event-loop": "^1.2",
"react/promise": "^3.0 || ^2.8 || ^1.2.1"
"react/promise": "dev-report-unhandled as 3.0.0"
},
"require-dev": {
"phpstan/phpstan": "1.10.18",
Expand All @@ -44,5 +44,11 @@
},
"autoload-dev": {
"psr-4": { "React\\Tests\\Async\\": "tests/" }
},
"repositories": {
"clue": {
"type": "vcs",
"url": "https://github.com/clue-labs/promise"
}
}
}
6 changes: 6 additions & 0 deletions tests/CoroutineTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@ public function testCoroutineShouldNotCreateAnyGarbageReferencesForPromiseReject
});
});

$promise->then(null, $this->expectCallableOnce()); // avoid reporting unhandled rejection

unset($promise);

$this->assertEquals(0, gc_collect_cycles());
Expand Down Expand Up @@ -232,6 +234,8 @@ public function testCoroutineShouldNotCreateAnyGarbageReferencesWhenGeneratorThr
yield; // @phpstan-ignore-line
});

$promise->then(null, $this->expectCallableOnce()); // avoid reporting unhandled rejection

unset($promise);

$this->assertEquals(0, gc_collect_cycles());
Expand All @@ -249,6 +253,8 @@ public function testCoroutineShouldNotCreateAnyGarbageReferencesWhenGeneratorYie
yield 42;
});

$promise->then(null, $this->expectCallableOnce()); // avoid reporting unhandled rejection

unset($promise);

$this->assertEquals(0, gc_collect_cycles());
Expand Down

0 comments on commit 9a3d930

Please sign in to comment.