Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up PHPStan on GitHub Actions #52

Closed
wants to merge 1 commit into from
Closed

Set up PHPStan on GitHub Actions #52

wants to merge 1 commit into from

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Sep 17, 2022

This PR sets up PHPStan to run on GitHub Actions, as discussed in discussions#469.

Overview

  • Sets up PHPStan to run on GitHub Actions on PHP 8.1 only
  • Configures PHPStan to run the analysis on the src and tests folders
  • Generates the baseline so that static analysis passes immediately

Baseline

Because this PR aims to set up PHPStan and not address the errors it reports, I've generated a baseline to make the pipeline succeed. We'll then be able to incrementally fix the problems in future PRs.

@nhedger nhedger closed this by deleting the head repository Apr 21, 2023
@clue
Copy link
Member

clue commented Jun 23, 2023

For the reference: It looks like this wasn't closed intentionally (as discussed in reactphp/async#64). We've recently started applying PHPStan on max level into our projects with reactphp/async#76 and we'll go ahead with this and apply PHPStan on max level to all our projects in the future.

Thank you very much for your contribution and sparking this discussion! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants