Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove call invoker related classes #65

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Remove call invoker related classes #65

merged 1 commit into from
Oct 28, 2019

Conversation

WyriHaximus
Copy link
Member

No description provided.

@WyriHaximus WyriHaximus changed the title Remove call invoker related classes [WIP] Remove call invoker related classes Apr 5, 2019
@WyriHaximus WyriHaximus force-pushed the remove-call-invokers branch from 1267363 to a17946a Compare May 4, 2019 10:28
@WyriHaximus WyriHaximus added this to the v0.2.0 milestone May 4, 2019
@WyriHaximus WyriHaximus force-pushed the remove-call-invokers branch 4 times, most recently from 264a3ce to a9ad131 Compare May 4, 2019 11:07
@ghost ghost mentioned this pull request May 5, 2019
Closed
@WyriHaximus WyriHaximus force-pushed the remove-call-invokers branch from a9ad131 to 0f6c071 Compare May 5, 2019 19:47
@ghost
Copy link

ghost commented Jul 9, 2019

@WyriHaximus 🏓 What's the current state?

@WyriHaximus
Copy link
Member Author

@CharlotteDunois It's a rabbithole I need to get back into, got some stuff locally but there are a lot of changes and EIO is being an issue.

@ghost
Copy link

ghost commented Oct 5, 2019

@WyriHaximus status?

@WyriHaximus
Copy link
Member Author

@CharlotteDunois nothing really changes, going for a stab at it again tonight

@WyriHaximus WyriHaximus force-pushed the remove-call-invokers branch from c32bc4b to 4d186f1 Compare October 6, 2019 20:42
@WyriHaximus WyriHaximus marked this pull request as ready for review October 6, 2019 20:45
@WyriHaximus WyriHaximus force-pushed the remove-call-invokers branch 5 times, most recently from 5dbb388 to 2d7c50a Compare October 7, 2019 09:34
@WyriHaximus WyriHaximus changed the title [WIP] Remove call invoker related classes Remove call invoker related classes Oct 7, 2019
@WyriHaximus WyriHaximus requested review from clue and jsor October 7, 2019 11:51
@clue
Copy link
Member

clue commented Oct 7, 2019

The less code, the better 👍 @WyriHaximus Can you add the appropriate labels (BC break etc.)?

ghost
ghost reviewed Oct 7, 2019
View reviewed changes
src/Eio/Adapter.php Outdated Show resolved Hide resolved
@WyriHaximus WyriHaximus force-pushed the remove-call-invokers branch from 2d7c50a to 9791ac4 Compare October 7, 2019 12:18
@WyriHaximus
Copy link
Member Author

The less code, the better @WyriHaximus Can you add the appropriate labels (BC break etc.)?

@clue done 👍

@ghost
Copy link

ghost commented Oct 16, 2019

@jsor 🏓

@jsor
Copy link
Member

jsor commented Oct 16, 2019

@WyriHaximus Tests are failing ❌

@WyriHaximus
Copy link
Member Author

@jsor thought about it merging anyway and fixing that in a follow up PR where it is clear where the issues resides. This also lets @CharlotteDunois continue with #69

@WyriHaximus WyriHaximus merged commit ea7d7e6 into reactphp:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
BC break maintenance
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WyriHaximus @clue @jsor