feat(snippets): splitting apart package and variable name configs #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
refactor
kanadgupta
approved these changes
Nov 8, 2023
Co-authored-by: Kanad Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This splits apart some confusing work I did in
httpsnippet-client-apiwhere I was always tying the@api/<package name>to the variable name if a custom variable name was supplied. For example if you supplied anidentifierofpetstoreandvariableNameofbuster, the variable name would bebusterbut@api/<package name>would also be@api/buster. Very confusing and not really now we intend this custom variable name support to be handled.Instead I've renamed the
identifieroption to the clearerpackageNameand added a new dedicatedvariableNameconfig for custom variable names. This small refactor will require a couple small changes to@readme/oas-to-snippet.