Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sqlalchemy #240

Merged
merged 17 commits into from
Feb 16, 2024
Merged

Feature/sqlalchemy #240

merged 17 commits into from
Feb 16, 2024

Conversation

zhPavel
Copy link
Member

@zhPavel zhPavel commented Feb 15, 2024

No description provided.

daler-sz
daler-sz suggested changes Feb 16, 2024
View reviewed changes
docs/reference/integrations.rst Outdated Show resolved Hide resolved
src/adaptix/_internal/model_tools/introspection/sqlalchemy.py Outdated Show resolved Hide resolved
src/adaptix/_internal/model_tools/introspection/sqlalchemy.py Outdated Show resolved Hide resolved
@daler-sz
Copy link
Member

daler-sz commented Feb 16, 2024 •
edited
Loading

I think code is good enough, except of minor omissions.
Also, I think that we should mention that we do not guarantee that tables mapped as dataclasses or attrs models work correctly.

@zhPavel zhPavel merged commit 0e044e6 into develop Feb 16, 2024
19 checks passed
@zhPavel zhPavel deleted the feature/sqlalchemy branch February 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daler-sz daler-sz daler-sz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhPavel @daler-sz