Allowing application to request logoutDisconnect in a session and spe… #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -267,9 +267,13 @@ | |||
| return string != null && string.length() > 0; | |||
| } | |||
|
|
|||
| public long sendLogout(final int msgSeqNo, final int sequenceIndex, final int lastMsgSeqNumProcessed) | |||
| public long sendLogout( | |||
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| @@ -408,13 +408,18 @@ | |||
| return acceptingSessionWriter.send(logon, adjustedMsgSeqNo); | |||
| } | |||
|
|
|||
| public long sendLogout(final int msgSeqNo, final int sequenceIndex, final int lastMsgSeqNumProcessed) | |||
| public long sendLogout( | |||
Check notice
Code scanning / CodeQL
Missing Override annotation Note test
lucianoviana
force-pushed
the
allowing-custom-text-in-logout
branch
from
9e162d7
to
b4f3015
Compare
wojciech-adaptive
requested changes
Jul 17, 2023
artio-core/src/main/java/uk/co/real_logic/artio/session/Session.java
Outdated
Show resolved
Hide resolved
artio-system-tests/src/test/java/uk/co/real_logic/artio/system_tests/SystemTestUtil.java
Outdated
Show resolved
Hide resolved
…cify a custom text
lucianoviana
force-pushed
the
allowing-custom-text-in-logout
branch
from
b4f3015
to
30ada28
Compare
|
i've just pushed again implementing your suggestions - thx |
wojciech-adaptive
approved these changes
Jul 20, 2023
pcdv
pushed a commit
to pcdv/artio
that referenced
this pull request
Apr 5, 2024
…cify a custom text (real-logic#488)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cify a custom text