Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add freelist verification at more points during commit #6763

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

finnschiermer
Copy link
Contributor

@finnschiermer finnschiermer commented Jul 3, 2023

Improve checks for free list corruptions

  • Enable some checks in release mode, which where otherwise only present in debug mode.
  • Run check for overlapping free blocks (free list corruption) in more places during commit.

This is in the hope of getting back better clues about the root cause of reported free list corruptions.

@finnschiermer finnschiermer marked this pull request as ready for review July 24, 2023 08:11
@finnschiermer
Copy link
Contributor Author

This is no longer needed.

@finnschiermer finnschiermer reopened this Oct 11, 2023
@finnschiermer finnschiermer removed the request for review from jedelbo October 11, 2023 13:09
@finnschiermer finnschiermer marked this pull request as draft October 11, 2023 13:09
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build github_pull_request_279261

  • 124 of 124 (100.0%) changed or added relevant lines in 2 files are covered.
  • 29 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.06%) to 91.624%

Files with Coverage Reduction New Missed Lines %
src/realm/object-store/sync/sync_manager.cpp 2 86.96%
src/realm/sync/noinst/client_impl_base.cpp 2 85.78%
src/realm/sync/noinst/server/server.cpp 2 75.83%
src/realm/table_view.cpp 2 94.18%
src/realm/sync/noinst/protocol_codec.hpp 3 76.21%
src/realm/util/future.hpp 3 95.81%
test/fuzz_group.cpp 3 51.61%
test/test_thread.cpp 3 66.67%
src/realm/util/file.cpp 4 81.73%
src/realm/util/fifo_helper.cpp 5 85.71%
Totals Coverage Status
Change from base Build 1745: 0.06%
Covered Lines: 230660
Relevant Lines: 251746

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant