Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing a logger through RealmConfig and SyncClientConfig #7231

Closed
wants to merge 2 commits into from

Conversation

kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented Jan 4, 2024

What, How & Why?

This is a proposal to fix #7227.
SDKs that take a logger factory could call it to get a logger before passing it though to the SDK, the main breaking change that cannot easily be poly-filled is the removal of SyncManager::set_logger_factory.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

Pull Request Test Coverage Report for Build kraen.hansen_46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 91.702%

Totals Coverage Status
Change from base Build 1938: -0.1%
Covered Lines: 232379
Relevant Lines: 253407

💛 - Coveralls

@jedelbo
Copy link
Contributor

jedelbo commented Jan 5, 2024

This is in conflict with commit b8aad6b, so I would like @tgoyne to comment,

@jedelbo jedelbo requested a review from tgoyne January 5, 2024 09:00
@tgoyne
Copy link
Member

tgoyne commented Jan 8, 2024

We don't need it to be a logger factory, but we do expose a way to set the logger after a SyncManager is created in our public API and so need that functionality to remain until our next major version bump.

@kraenhansen
Copy link
Member Author

Closing as it's unlikely this will ever merge.

@kraenhansen kraenhansen closed this Oct 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing logger through RealmConfig on SharedRealm::get_shared_realm
3 participants