Reuse transaction when refreshing subscriptions after commit #8068
+9
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build jonathan.reams_3585Details
💛 - Coveralls |
|
I've confirmed this fixed the issue we were seeing with Realm Core v14.13.4 via realm/realm-js#6961 |
jedelbo
reviewed
Jan 27, 2025
src/realm/sync/subscriptions.cpp
Outdated
| @@ -970,9 +964,9 @@ SubscriptionSet SubscriptionStore::get_by_version(int64_t version_id) | |||
| throw KeyNotFound(util::format("Subscription set with version %1 not found", version_id)); | |||
| } | |||
|
|
|||
| SubscriptionSet SubscriptionStore::get_refreshed(ObjKey key, int64_t version, std::optional<DB::VersionID> db_version) | |||
| SubscriptionSet SubscriptionStore::get_refreshed(ObjKey key, int64_t version, std::optional<TransactionRef> maybe_tr) | |||
There was a problem hiding this comment.
Perhaps you don't need std::optional here. TransactionRef is already a pointer type that can be checked for null.
There was a problem hiding this comment.
I think its clearer with the optional.
There was a problem hiding this comment.
It's just that we have a tradition for checking the pointer directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Instead of throwing the read transaction away after committing subscription changes and then opening a new frozen transaction at the committed transaction's version - we should just re-use the read transaction.
☑️ ToDos
bindgen/spec.yml, if public C++ API changed