`@realm/react` key-path filtering on `useQuery` and `useObject` #6360

kraenhansen · 2024-01-09T20:39:52Z

What, How & Why?

This closes #6286

☑️ ToDos

Figure out a way to document the overload of useQuery
📝 Changelog entry
📝 Compatibility label is updated or copied from previous entry
📝 Update COMPATIBILITY.md
🚦 Tests
📦 Updated internal package version in consuming package.jsons (if updating internal packages)
📱 Check the React Native/other sample apps work if necessary
💥 Breaking label has been applied or is not necessary

kraenhansen · 2024-01-09T20:40:28Z

packages/realm-react/src/index.tsx

@@ -93,6 +93,7 @@ type RealmContext = {
   * ```
   * @param type - The object type, depicted by a string or a class extending {@link Realm.Object}
   * @param primaryKey - The primary key of the desired object which will be retrieved using {@link Realm.objectForPrimaryKey}
+   * @param keyPaths - Indicates a lower bound on the changes relevant for the hook. This is a lower bound, since if multiple hooks add listeners (each with their own `keyPaths`) the union of these key-paths will determine the changes that are considered relevant for all listeners registered on the object. In other words: A listener might fire and cause a re-render more than the key-paths specify, if other listeners with different key-paths are present.


I've added this here, but I still need to figure out a way to document the overload on useQuery.

Should we deprecate the previous overloads? Then you can just document the new way and mention the old as deprecated.

kraenhansen · 2024-01-09T20:41:07Z

packages/realm-react/src/useQuery.tsx

-    // We want the user of this hook to be able pass in the `query` function inline (without the need to `useCallback` on it)
-    // This means that the query function is unstable and will be a redefined on each render of the component where `useQuery` is used
-    // Therefore we use the `deps` array to memoize the query function internally, and only use the returned `queryCallback`
+    /* eslint-disable-next-line react-hooks/exhaustive-deps -- We want the user of this hook to be able pass in the `query` function inline (without the need to `useCallback` on it)


Turned this comment into an eslint-disable-next-line comment to silence the warning.

kraenhansen · 2024-01-09T20:41:50Z

packages/realm-react/src/__tests__/createRealmTestContext.ts

+ * Opens a test realm at a random temporary path.
+ * @returns The `realm` and a `write` function, which will wrap `realm.write` with an `act` and prepand a second `realm.write` to force notifications to trigger.
+ */
+export function createRealmTestContext(rootConfig: Configuration = {}): RealmTestContext {


I've added this helper, to make it easier to work with Realms in the tests.

kraenhansen · 2024-01-09T20:42:35Z

packages/realm-react/src/__tests__/createRealmTestContext.ts

+      act(() => {
+        context.realm.write(callback);
+        // Starting another write transaction will force notifications to fire
+        context.realm.beginTransaction();
+        context.realm.cancelTransaction();
+      });


This simplifies the test code quite a bit, ensuring act is called and applying the workaround to force notifications to fire.

Were notifications not firing without that workaround?

Were notifications not firing without that workaround?

Yes, but they only fire when the database advances, which happens asynchronously if not pressured by an explicit write transaction. This force the notifications to fire synchronously.
(I'll add that last word to the comment in the code).

kraenhansen · 2024-01-09T20:44:25Z

I'm drafting this to get some early feedback, I might want to merge another PR updating our TypeScript version to > 5.0 to get support for @overload in jsdocs 🤔

coveralls-official · 2024-01-09T20:45:25Z

coverage: 85.346%. remained the same
when pulling ed9774e on kh/realm-react-key-path-notifications
into 7954133 on main.

takameyer

Great updates here. I really like the helpers for the tests.
I guess the only question is, should we deprecate the old argument methods for useQuery? Would be great to see that marked in consumer code so that it was apparent one should refactor.

kraenhansen · 2024-01-10T08:02:51Z

should we deprecate the old argument methods for useQuery?

I thought about it, but I'd rather not deprecate something, pointing to another API, that also won't be the preferred way long-term.
I hope something like #6284 is the future 🤞 Although we need to incorporate keyPaths in that proposal 🤔

kneth · 2024-01-10T11:00:54Z

packages/realm-react/src/__tests__/createRealmTestContext.ts

+};
+
+/**
+ * Opens a test realm at a random temporary path.


Suggested change

* Opens a test realm at a random temporary path.

* Opens a test realm at a randomized and temporary path.

kneth · 2024-01-10T12:50:47Z

packages/realm-react/src/index.tsx

@@ -93,6 +93,7 @@ type RealmContext = {
   * ```
   * @param type - The object type, depicted by a string or a class extending {@link Realm.Object}
   * @param primaryKey - The primary key of the desired object which will be retrieved using {@link Realm.objectForPrimaryKey}
+   * @param keyPaths - Indicates a lower bound on the changes relevant for the hook. This is a lower bound, since if multiple hooks add listeners (each with their own `keyPaths`) the union of these key-paths will determine the changes that are considered relevant for all listeners registered on the object. In other words: A listener might fire and cause a re-render more than the key-paths specify, if other listeners with different key-paths are present.


Could you give an example?

Good idea, an @example could be nice. And if so, the same example could be added to the docs in the realm package part as well.

kneth · 2024-01-10T12:51:56Z

packages/realm-react/src/useObject.tsx

@@ -58,12 +63,16 @@ export function createUseObject(useRealm: () => Realm) {
    // Ref: https://github.com/facebook/react/issues/14490
    const cachedObjectRef = useRef<null | CachedObject>(null);

+    /* eslint-disable-next-line react-hooks/exhaustive-deps -- Memoizing the keyPaths to avoid renders */
+    const memoizedKeyPaths = useMemo(() => keyPaths, [JSON.stringify(keyPaths)]);


Hard not to read "memorized" 🤣

elle-j

Great updates!

elle-j · 2024-01-12T10:49:36Z

packages/realm-react/src/__tests__/createRealmTestContext.ts

+      act(() => {
+        context.realm.write(callback);
+        // Starting another write transaction will force notifications to fire
+        context.realm.beginTransaction();
+        context.realm.cancelTransaction();
+      });


Were notifications not firing without that workaround?

elle-j · 2024-01-12T11:01:14Z

packages/realm-react/src/__tests__/useObjectHook.test.tsx

+    context.openRealm();
+    const { realm } = context;


What if the openRealm() on the context could return the realm as well? Then in places like this one you don't have to use context.realm or context.useRealm().

elle-j · 2024-01-12T11:13:33Z

packages/realm-react/src/__tests__/useQueryHook.test.tsx

@@ -111,4 +97,74 @@ describe("useQueryHook", () => {

    expect(collection[99]).toBe(undefined);
  });
+
+  it("can filter objects via a query argument", () => {


What do you think of updating the ..via a query option and ..via a query argument test names to e.g. ..via an option argument and ..via separate type and callback arguments. I initially interperted the "query argument" part as testing for e.g. $0 etc in the query.

I updated the names 🤞

elle-j · 2024-01-12T11:24:16Z

packages/realm-react/src/index.tsx

@@ -93,6 +93,7 @@ type RealmContext = {
   * ```
   * @param type - The object type, depicted by a string or a class extending {@link Realm.Object}
   * @param primaryKey - The primary key of the desired object which will be retrieved using {@link Realm.objectForPrimaryKey}
+   * @param keyPaths - Indicates a lower bound on the changes relevant for the hook. This is a lower bound, since if multiple hooks add listeners (each with their own `keyPaths`) the union of these key-paths will determine the changes that are considered relevant for all listeners registered on the object. In other words: A listener might fire and cause a re-render more than the key-paths specify, if other listeners with different key-paths are present.


Good idea, an @example could be nice. And if so, the same example could be added to the docs in the realm package part as well.

elle-j · 2024-01-17T16:35:54Z

packages/realm-react/src/useQuery.tsx

+type QueryHookOptions<T> = {
+  type: string;
+  query?: QueryCallback<T>;
+  keyPaths?: string[];
+};
+
+type QueryHookClassBasedOptions<T> = {
+  type: RealmClassType<T>;
+  query?: QueryCallback<T>;
+  keyPaths?: string[];
+};


Just realized that we should probably allow keyPaths?: string | string[] rather than just string[] since we do that in the realm package. Same for useObject.

I updated the API to allow a single string too.

kraenhansen · 2024-01-22T13:07:43Z

I think this just needs a rebase and the inline doc comments needs a final update.

kraenhansen · 2024-01-29T15:15:17Z

I believe this is finally ready for review. Unfortunately the upgrade to TS 5+ didn't solve the issue of missing support for @overload in doc comments.

I've created TypeStrong/typedoc#2492 in hopes we could get typedoc support for this - in the meantime I would love ideas on how to document this.

takameyer · 2024-01-30T07:25:54Z

packages/realm-react/src/index.tsx

@@ -82,6 +80,44 @@ type RealmContext = {
   * @param deps - An array of dependencies that will be passed to {@link React.useMemo}
   * @returns a collection of realm objects or an empty array
   */
+
+  /**
+   * @overload


In lieu of difficulties with the "overload" flag, why not just simplify the documentation down to what the desired usage is?
The type system can still handle the previous usage. My 2 cents.

the desired usage is?

Sure - but I don't know if I actually know what that is 🤔 I guess we could focus on passing an object and use this as a fix for #6259 and eventually make this more convenient via #6284?

In my opinion, passing as an object is the desired usage. If I would have thought of it earlier, it would be the only way to do it.

If we do that, we could also @deprecate the existing signature for useQuery?

Yes, I think that's the way forward. We are still on version 0.x.y, so we can make some broader changes. I think in the end it makes things more extensible if we want to add more options to the hooks

I've updated the docs to focus solely on the signature where an options object is passed 👍

The README should also be updated. Or perhaps we should just simplify the README to point to the docs page 🤔

I'm contemplating adding an overload, passing just the type as first argument to avoid deprecation of that:

const cars = useQuery(Car);

feels cleaner than

const cars = useQuery({ type: Car });

Yeah, that's cleaner, but it's not "that" bad.

takameyer

Looks great 👍🏼

takameyer · 2024-01-30T07:31:33Z

packages/realm-react/src/__tests__/profileHook.tsx

+//
+////////////////////////////////////////////////////////////////////////////
+
+import React, { Profiler, ProfilerOnRenderCallback } from "react";


Nice usage of the Profiler here 👍🏼

takameyer · 2024-01-30T07:34:41Z

packages/realm-react/src/useObject.tsx

+
+export type UseObjectHook = {
+  <T>(type: string, primaryKey: T[keyof T], keyPaths?: string | string[]): (T & Realm.Object<T>) | null;
+  <T extends Realm.Object<any>>(type: { new (...args: any): T }, primaryKey: T[keyof T], keyPaths?: string | string[]): T | null;


Appears we have a lint failure here and elsewhere

elle-j

Great addition, getting closer to letting users try this out 🚀

packages/realm-react/src/__tests__/useObjectHook.test.tsx

elle-j · 2024-01-31T10:09:36Z

packages/realm-react/src/__tests__/useObjectHook.test.tsx

+      // Update the age and don't expect a re-render
+      write(() => {
+        if (result.current) {
+          result.current.age = 5;
+        }
+      });
+      expect(renders).toHaveLength(2);


If result.current is falsy (and we thereby don't update the age), then the test may still pass since there is no new rerender. You do check the result.current in the expect before write(), so perhaps that's enough, but we could e.g. add an else clause in the callback and throw an error to make sure we test that the update doesn't cause a rerender in this case. (There's one more occurrence of this I believe.)

Good catch, this should probably just assert result.current instead 👍

elle-j · 2024-01-31T10:12:57Z

packages/realm-react/src/__tests__/useQueryHook.test.tsx

@@ -69,20 +52,22 @@ const testDataSet = [
  { _id: 6, name: "Sadie", color: "gold", gender: "female", age: 5 },
 ];

-describe("useQueryHook", () => {
+describe("useQuery", () => {
+  const context = createRealmTestContext({ schema: [dogSchema] });


Similar comment as before (could destructure this here instead if you prefer).

packages/realm-react/src/index.tsx

elle-j · 2024-01-31T10:42:01Z

packages/realm-react/src/useObject.tsx

+export type UseObjectHook = {
+  <T>(type: string, primaryKey: T[keyof T], keyPaths?: string | string[]): (T & Realm.Object<T>) | null;
+  <T extends AnyRealmObject>(
+    type: { new (...args: any): T },
+    primaryKey: T[keyof T],
+    keyPaths?: string | string[],
+  ): T | null;
+};


Since we're now deprecating the usage of separate arguments for useQuery() in favor of an options arg, it introduces some inconsistency between that API and that of useObject(). Even though useObject() doesn't have the ESLint issue regarding dependency lists, I think we should consider allowing an options argument for that hook as well, especially since the third arg keyPaths has been introduced.

I'd be interested in hearing your thoughts on this @kraenhansen @takameyer .

Good consideration. I would be in favor of using an options object for useObject().

True -- that would probably be more consistent and read better for some users 👍

I've pushed an update including that 👍

Yeah I think so too. ~~If updated in this PR, remember potential README and docs updates as well~~ (saw your last comment now) 👍

packages/realm-react/src/useQuery.tsx

Co-authored-by: LJ <[email protected]>

… helpers

kraenhansen · 2024-01-31T12:36:40Z

To get the typedocs for these overloads to shine, I think I'll need to sink a bit more time into the way we export the functions from the default context in our index.ts 🤔

takameyer

LGTM. Does this need to be in draft? Maybe just a follow up PR for the documentation pieces.

packages/realm-react/CHANGELOG.md

Co-authored-by: Andrew Meyer <[email protected]>

kraenhansen · 2024-02-16T09:07:41Z

Does this need to be in draft? Maybe just a follow up PR for the documentation pieces.

I think you're right. I should probably just follow up with a PR to improve that documentation as this doesn't decrease the DX in and of itself.

kraenhansen · 2024-02-16T15:35:35Z

I've merged this as is and will follow up with updates to the docs of this once I get the docs for the entire package refactored a bit 👍

@overload

…m#6360) * Seperated types from hook functions * Adding a helper to generate a random realm path * Use eslint-disable-next-line comment to disable a warning * Adding a profileHook utility on-top-of renderHook * Adding overloads to useQuery * Adding failing tests * Refactored tests into using a "realm test context" * Passing key-paths through useQuery into the SDK's addListener method * Reusing randomRealmPath * Made useObject tests use createRealmTestContext * adding a useObject test for re-render on object creation * Implement keyPaths on useObject * Incorporating feedback * Allow passing a string as "keyPaths" * Exporting types * Adding @overload doc comments * Focusing docs on the desired call-pattern * Ran lint --fix * Adding a AnyRealmObject utility type * Using the `options` overload in the readme * Adding a non-deprecated single argument overload * Apply suggestions from code review Co-authored-by: LJ <[email protected]> * Using asserts instead of if-statements * Moved RealmClassType, AnyRealmObject and isClassModelConstructor into helpers * Implemented options object overload on useObject hook * Adding a note to the changelog * Update packages/realm-react/CHANGELOG.md Co-authored-by: Andrew Meyer <[email protected]> --------- Co-authored-by: LJ <[email protected]> Co-authored-by: Andrew Meyer <[email protected]>

kraenhansen self-assigned this Jan 9, 2024

kraenhansen commented Jan 9, 2024

View reviewed changes

kraenhansen requested review from takameyer and elle-j January 9, 2024 20:42

kraenhansen marked this pull request as draft January 9, 2024 20:42

takameyer reviewed Jan 10, 2024

View reviewed changes

kneth reviewed Jan 10, 2024

View reviewed changes

elle-j reviewed Jan 12, 2024

View reviewed changes

elle-j reviewed Jan 17, 2024

View reviewed changes

kraenhansen added 12 commits January 29, 2024 14:21

Seperated types from hook functions

ed6558b

Adding a helper to generate a random realm path

1e96013

Use eslint-disable-next-line comment to disable a warning

74fdcac

Adding a profileHook utility on-top-of renderHook

056df66

Adding overloads to useQuery

88f53c1

Adding failing tests

8330c9a

Refactored tests into using a "realm test context"

340aec4

Passing key-paths through useQuery into the SDK's addListener method

e745dfb

Reusing randomRealmPath

67b22af

Made useObject tests use createRealmTestContext

b12282b

adding a useObject test for re-render on object creation

995cf7d

Implement keyPaths on useObject

307dc1b

kraenhansen force-pushed the kh/realm-react-key-path-notifications branch from fb613d7 to 307dc1b Compare January 29, 2024 13:21

cla-bot bot added the cla: yes label Jan 29, 2024

Exporting types

0a8daef

kraenhansen marked this pull request as ready for review January 29, 2024 15:13

Adding @overload doc comments

fa91205

takameyer reviewed Jan 30, 2024

View reviewed changes

takameyer approved these changes Jan 30, 2024

View reviewed changes

kraenhansen added 5 commits January 30, 2024 12:29

Focusing docs on the desired call-pattern

7dd55c8

Ran lint --fix

fc9fe8a

Adding a AnyRealmObject utility type

a566a53

Using the options overload in the readme

8f568f6

Adding a non-deprecated single argument overload

804fa6d

elle-j approved these changes Jan 31, 2024

View reviewed changes

kraenhansen and others added 5 commits January 31, 2024 12:21

Apply suggestions from code review

2a165ca

Co-authored-by: LJ <[email protected]>

Using asserts instead of if-statements

0f6eb61

Moved RealmClassType, AnyRealmObject and isClassModelConstructor into…

3483dc9

… helpers

Implemented options object overload on useObject hook

110eaf8

Adding a note to the changelog

96bfc10

kraenhansen requested review from takameyer and elle-j January 31, 2024 11:54

kraenhansen marked this pull request as draft January 31, 2024 13:01

takameyer approved these changes Feb 16, 2024

View reviewed changes

packages/realm-react/CHANGELOG.md Outdated Show resolved Hide resolved

Update packages/realm-react/CHANGELOG.md

ed9774e

Co-authored-by: Andrew Meyer <[email protected]>

kraenhansen marked this pull request as ready for review February 16, 2024 15:34

kraenhansen merged commit b54d7f6 into main Feb 16, 2024
9 checks passed

kraenhansen deleted the kh/realm-react-key-path-notifications branch February 16, 2024 15:34

github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024

	* Opens a test realm at a random temporary path.
	* Opens a test realm at a randomized and temporary path.

@realm/react key-path filtering on useQuery and useObject #6360

@realm/react key-path filtering on useQuery and useObject #6360

Conversation

kraenhansen commented Jan 9, 2024

What, How & Why?

☑️ ToDos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kraenhansen Jan 29, 2024 • edited Loading

Choose a reason for hiding this comment

kraenhansen commented Jan 9, 2024

coveralls-official bot commented Jan 9, 2024 • edited Loading

takameyer left a comment

Choose a reason for hiding this comment

kraenhansen commented Jan 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elle-j left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elle-j Jan 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kraenhansen commented Jan 22, 2024

kraenhansen commented Jan 29, 2024

takameyer Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kraenhansen Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

takameyer Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

takameyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elle-j left a comment

Choose a reason for hiding this comment

elle-j Jan 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kraenhansen Jan 31, 2024 • edited Loading

Choose a reason for hiding this comment

elle-j Jan 31, 2024 • edited Loading

Choose a reason for hiding this comment

kraenhansen commented Jan 31, 2024 • edited Loading

takameyer left a comment

Choose a reason for hiding this comment

kraenhansen commented Feb 16, 2024

kraenhansen commented Feb 16, 2024

`@realm/react` key-path filtering on `useQuery` and `useObject` #6360

`@realm/react` key-path filtering on `useQuery` and `useObject` #6360

kraenhansen Jan 29, 2024 •

edited

Loading

coveralls-official bot commented Jan 9, 2024 •

edited

Loading

elle-j Jan 17, 2024 •

edited

Loading

takameyer Jan 30, 2024 •

edited

Loading

kraenhansen Jan 30, 2024 •

edited

Loading

takameyer Jan 30, 2024 •

edited

Loading

elle-j Jan 31, 2024 •

edited

Loading

kraenhansen Jan 31, 2024 •

edited

Loading

elle-j Jan 31, 2024 •

edited

Loading

kraenhansen commented Jan 31, 2024 •

edited

Loading