-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional tests for collections in mixed #6648
base: main
Are you sure you want to change the base?
Commits on Apr 26, 2024
-
Implement support for flat collections in
Mixed
(#6364)* Differentiate use of 'mixedToBinding()' for query arg validation. * Refactor 'mixedFromBinding()' to own function and account for List and Dictionary. * Implement setting a flat list and dictionary in Mixed. * Implement accessing a flat list and dictionary in Mixed. * Add tests for storing and accessing flat lists and dictionaries in Mixed. * Refactor helper in test to not rely on collection position. * Add tests for Set in Mixed throwing. * Add tests for updating lists and dictionaries. * Add tests for removing items in lists and dictionaries. * Add tests for filtering lists and dictionaries by path. * Throw if adding a set via property accessors. * Group tests into separate sub-suites. * Guard for embedded objects being set as Mixed value. * Add tests for embedded objects in Mixed throwing. * Add more filtering tests. * Add 'at_keys' query tests to uncomment after Core bug fix. * Add tests for inserting into lists and dictionaries. * Add tests for notifications on lists. * Add tests for notifications on dictionaries. * Add tests for notifications on object when changed prop is list in mixed. * Add tests for invalidating old list and dictionary. * Minor updates to names. * Add tests for notifications on object when changed prop is dictionary in mixed. * Add tests for creating dictionary via object without prototype. * Add tests filtering by query path using IN. * Access array of changes only 1 time in notifications tests. * Remove unnecessary type assertion. * Update schema object names in tests. * Add link to Core bug. * Add tests for default list and dictionary in schema. * Add tests for setting lists and dictionaries outside transaction. * Add tests for spreading Realm and non-Realm objects as Dictionary. * Add unit tests for 'isPOJO()'. * Point to updated Core commit and enable related tests. * Wrap chai's 'instanceOf()' in custom helper to assert type. * Update helper function name to be consistent with other helpers. * Add internal docs for 'isQueryArg'. * Rename unit test file. * Refactor notification tests into 'observable.ts'. * Refactor notification tests to use test context. * Use named import of 'ObjectSchema'. * Group CRUD tests into subsuites.
Configuration menu - View commit details
-
Copy full SHA for aa5b287 - Browse repository at this point
Copy the full SHA aa5b287View commit details -
RJS-2680: Implement support for
Mixed
data type with nested collect……ions (#6513) * Move geospatial helper functions to related file. * Implement setting nested lists in Mixed. * Implement setting nested dictionaries in Mixed. * Implement getting nested lists in Mixed. * Implement getting nested dictionaries in Mixed. * Test creating and accessing nested lists and dicts. * Make previous flat collections tests use the new 'expect' function. * Test that max nesting level throws. * Delegate throwing when using a Set to 'mixedToBinding()'. * Implement setting nested collections on a dictionary via setter. * Test nested collections on dictionary via setter. * Minor update to names of tests. * Combine nested and flat collections tests into same suite. * Implement setting nested collections on a list via setter. * Test nested collections on list via setter. * Refactor common test logic to helper functions. * Optimize property setter for hot-path and use friendlier err msg. * Refactor test helper function to build collections of any depth. * Implement inserting nested collections on a list via 'push()'. * Test nested collections on a list via 'push()'. * Test updating dictionary entry to nested collections via setter. * Test updating nested list/dictionary item via setter. * Test removing items from collections via 'remove()'. * Test object notifications when modifying nested collections. * Group previous notification tests into one test. * Group collection notifications tests into 'List' and 'Dictionary'. * Test collection notifications when modifying nested collections. * Remove collections from test context. * Test filtering by query path on nested collections. * Align object schema property names in tests. * Test filtering with int at_type. * Implement setting nested collections on a dictionary via 'set()' overloads. * Test JS Array method 'values()'. * Test JS Array method 'entries()'. * Implement getting nested collections on dictionary 'values()' and 'entries()'. * Test 'values()' and 'entries()' on dictionary with nested collections. * Remove unnecessary 'fromBinding()' calls. * Refactor collection helpers from 'PropertyHelpers' into the respective collection file. * Introduce list/dict sentinels to circumvent extra Core access. * Rename getter to default. * Remove redundant 'snapshotGet'. * Add abstract 'get' and 'set' to 'OrderedCollection'. * Rename the collection helpers to 'accessor'. * Move tests into subsuites. * Fix 'Results.update()'. * Support nested collections in 'pop()', 'shift()', 'unshift()', 'splice()'. * Test list 'pop()'. * Test list 'shift()'. * Test list 'unshift()'. * Test list 'splice()'. * Return 'not found' for collections searched for in 'indexOf()'. * Test ordered collection 'indexOf()'. * Support list/dict sentinels in JSI. * Test references per access. * Enable skipped tests after Core bug fix. * Point to updated Core. * Fix accessor for non-Mixed top-level collection with Mixed items. * Enable and fix previously skipped test. * Update 'mixed{}'. * Update 'mixed<>'. * Remove now-invalidated test. * Remove unused injectable from Node bindgen template. * Replace if-statements with switch. * Add explicit Results and Set accessors for Mixed. * Adapt to change in Core treating missing keys as null in queries. * Rename insertion function. * Include tests of Dictionary property type with Mixed. * Test reassigning to new collection and self-assignment. * Test mixed * Update 'mixed[]'. * Test results accessor. * Update error messages. * Make accessor helpers an object field rather than spread. * Suggestions for "nested collections in mixed" (#6566) * Fix type bundling issue * Inline functions into "create*Accessor*" functions * Refactored typeHelpers out of accessors * Remove leftover 'Symbol_for' in node-wrapper template. * Test not invalidating new collection. * Remove test for max nesting level. The max nesting level in debug in Core has been updated to be the same as for release. * Remove reliance on issue-fix in certain tests. * Add key path test for object listener on mixed field. * Use '.values()' and '.entries()' in iteration. * Update comments. * Add CHANGELOG entry. --------- Co-authored-by: Kræn Hansen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f27d77e - Browse repository at this point
Copy the full SHA f27d77eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aeb1749 - Browse repository at this point
Copy the full SHA aeb1749View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7d21e7 - Browse repository at this point
Copy the full SHA b7d21e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c20dede - Browse repository at this point
Copy the full SHA c20dedeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dca996 - Browse repository at this point
Copy the full SHA 1dca996View commit details -
Configuration menu - View commit details
-
Copy full SHA for e675112 - Browse repository at this point
Copy the full SHA e675112View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec9f30f - Browse repository at this point
Copy the full SHA ec9f30fView commit details
Commits on Apr 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42f6814 - Browse repository at this point
Copy the full SHA 42f6814View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a6b8c4 - Browse repository at this point
Copy the full SHA 5a6b8c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b960fd5 - Browse repository at this point
Copy the full SHA b960fd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3991bec - Browse repository at this point
Copy the full SHA 3991becView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5502110 - Browse repository at this point
Copy the full SHA 5502110View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e4e18c - Browse repository at this point
Copy the full SHA 6e4e18cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 889fcfe - Browse repository at this point
Copy the full SHA 889fcfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b8ff49 - Browse repository at this point
Copy the full SHA 0b8ff49View commit details -
Configuration menu - View commit details
-
Copy full SHA for f303fda - Browse repository at this point
Copy the full SHA f303fdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 883d26c - Browse repository at this point
Copy the full SHA 883d26cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71c341c - Browse repository at this point
Copy the full SHA 71c341cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bf02b3 - Browse repository at this point
Copy the full SHA 3bf02b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5808ee6 - Browse repository at this point
Copy the full SHA 5808ee6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f305970 - Browse repository at this point
Copy the full SHA f305970View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51bbdf1 - Browse repository at this point
Copy the full SHA 51bbdf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46150ae - Browse repository at this point
Copy the full SHA 46150aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab512bb - Browse repository at this point
Copy the full SHA ab512bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2c1a4e - Browse repository at this point
Copy the full SHA d2c1a4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 105054d - Browse repository at this point
Copy the full SHA 105054dView commit details -
Apply suggestions from code review
Co-authored-by: LJ <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ba5ec50 - Browse repository at this point
Copy the full SHA ba5ec50View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9c7470 - Browse repository at this point
Copy the full SHA b9c7470View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba48135 - Browse repository at this point
Copy the full SHA ba48135View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89de282 - Browse repository at this point
Copy the full SHA 89de282View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2711dd8 - Browse repository at this point
Copy the full SHA 2711dd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e56b233 - Browse repository at this point
Copy the full SHA e56b233View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71e8524 - Browse repository at this point
Copy the full SHA 71e8524View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa9d2ea - Browse repository at this point
Copy the full SHA fa9d2eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14e9a32 - Browse repository at this point
Copy the full SHA 14e9a32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ec8d25 - Browse repository at this point
Copy the full SHA 2ec8d25View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7894f4 - Browse repository at this point
Copy the full SHA f7894f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f81629 - Browse repository at this point
Copy the full SHA 8f81629View commit details
Commits on May 1, 2024
-
Merge branch 'fp/collections-mixed-sync-tests' into fp/collections-mi…
…xed-sync-tests-additional * fp/collections-mixed-sync-tests: Added comment Removed only Corrected testing trying to improve testing Removed realm use Remove unused # Conflicts: # integration-tests/tests/src/tests/sync/mixed.ts
Configuration menu - View commit details
-
Copy full SHA for 6c51611 - Browse repository at this point
Copy the full SHA 6c51611View commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4aeb008 - Browse repository at this point
Copy the full SHA 4aeb008View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67abfe9 - Browse repository at this point
Copy the full SHA 67abfe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0c3ffc - Browse repository at this point
Copy the full SHA f0c3ffcView commit details
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3c3bde9 - Browse repository at this point
Copy the full SHA 3c3bde9View commit details