Add progress callback to asynchronous async await initialiser for Realm
#8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowungiles
reviewed
Nov 24, 2022
| @@ -1217,13 +1218,18 @@ extension Realm { | |||
| } | |||
| case .always: | |||
| rlmRealm = try await withCheckedThrowingContinuation { continuation in | |||
| RLMRealm.asyncOpen(with: configuration.rlmConfiguration, callbackQueue: .main) { (realm, error) in | |||
| let rlmTask = RLMRealm.asyncOpen(with: configuration.rlmConfiguration, callbackQueue: .main) { (realm, error) in | |||
There was a problem hiding this comment.
Hey @dianaafanador3 thanks for the PR. Looking good.
What was your reasoning for fixing the callbackQueue to .main rather than letting an implementer pass in their preffered queue?
There was a problem hiding this comment.
Because you can only run let realm = try await Realm() at the moment, in a @mainactor.
We are still discussing if this is the bet API for this, but we have a project in progress which should give better support for actor-confined Realms and offer a better experience with Swift concurrency in general, which should include exposing recurring callbacks as AsyncSequences for sync progress notification.
There was a problem hiding this comment.
That's great, thanks @dianaafanador3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extending the API for
Realm.init()async to have a callback for progress notifications. Feature request here #7763.