Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample code for the article on lists vs tuples #567

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

lpozo
Copy link
Contributor

@lpozo lpozo commented Aug 14, 2024

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Copy link
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpozo I'd suggest to use underscores for the script names, so that they can potentially also be moduels. Probably no one will use them like that, but I think we're generally naming Python files with underscores in this repo.

Also, a small change to show more output in the unpacking file.

python-lists-tuples/unpacking.py Outdated Show resolved Hide resolved
@martin-martin
Copy link
Contributor

Great, looks good to me ✅

@brendaweles brendaweles merged commit 7dd6834 into master Aug 23, 2024
1 check passed
@brendaweles brendaweles deleted the python-lists-tuples-update branch August 23, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants