WIP Prettier Printing of function calls DO NOT MERGE #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordwalke
commented
Dec 6, 2022
| type variant = | ||
| | X(int, int) /* End of line on X */ | ||
| | Y(int, int); /* End of line on Y */ /* Comment on entire type def for variant */ | ||
| type variant = | X(int, int) /* End of line on X */ |
There was a problem hiding this comment.
This is a regression obviously.
jordwalke
commented
Dec 6, 2022
| n + tmp; | ||
| | None => 20 | ||
| }; | ||
| let result = switch (None) { |
There was a problem hiding this comment.
This is the right idea.
jordwalke
commented
Dec 6, 2022
| | Y(_) => "result of Y" /* End of arrow and Y line */ | ||
| }; | ||
|
|
||
| type optionalTuple = | OptTup( |
jordwalke
commented
Dec 6, 2022
| ), | ||
| ), | ||
| ); | ||
|
|
jordwalke
commented
Dec 6, 2022
| 1, /*eol1*/ | ||
| 2 /* eol2 */ | ||
| ); | ||
| let y = TwoArgsConstructor( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates how to achieve prettier printing of function calls. Sending a PR just for discussion. It is based on a really old commit of Reason, but shouldn't be too hard to rebase and fix the regressions.
Instead of:
It will print:
In its current state it also applies the same convention to other constructs which should not be wrapped in that manner - it's just a matter of going through and telling the printer which style to use in each case.
I included some test output changes which demonstrate both some improvements and some regressions in printing.