Upgrade to be terraform .12 compatible & other changes Fixes #16 #5 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need failure event because we only know for sure that the user wants to be informed of a failure. Other events a user might not care about. Also there is already alarm for low storage.
this module is just for alarms we know it applies to alarms already so no need to state it
|
Ah darnit, I accidentily opened the PR against a fork instead of the main repo. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db_instance_idchanged todb_instance_idsto support multiple db'salarm_periodandalarm_evaluation_periodsparamsWe are running this change in production for 15Five.