Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #249

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Fix typo #249

merged 2 commits into from
Sep 9, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 9, 2023 •
edited
Loading

should fix

TypeError: Rector\NodeNameResolver\NodeNameResolver::matchesStringName(): Argument #1 ($resolvedName) must be of type string, PhpParser\Node\Identifier given, called in /home/runner/work/rector-src/rector-src/src/Rector/Class_/PreferPHPUnitSelfCallRector.php on line 94

followup to #248

@TomasVotruba
Copy link
Member

This is also fine 🙂

@staabm
Copy link
Contributor Author

staabm commented Sep 9, 2023

@TomasVotruba please merge my oversight :)

@TomasVotruba TomasVotruba merged commit 7b173b9 into rectorphp:main Sep 9, 2023
3 of 5 checks passed
@staabm staabm deleted the patch-1 branch September 9, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @TomasVotruba