[code-quality] Add NarrowUnusedSetUpDefinedPropertyRector #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasVotruba
commented
Nov 3, 2024
TomasVotruba
commented
- misc
- [code-quality] Add NarrowUnusedSetUpDefinedPropertyRector
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-narrow-setup-defined-properties
branch
from
6920fe0
to
28df854
Compare
TomasVotruba
force-pushed
the
tv-narrow-setup-defined-properties
branch
from
28df854
to
c38e16a
Compare
samsonasik
reviewed
Nov 3, 2024
Comment on lines
+111
to
+113
| if (! $this->isPropertyUsedOutsideSetUpClassMethod($node, $setUpClassMethod, $property)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
the check is flipped, continue should check when property is used
There was a problem hiding this comment.
ok, it seems fixed at f24bef5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.