Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHPUnit 10] Skip with Magic __get() on AssertIssetToAssertObjectHasPropertyRector #403

Merged
merged 3 commits into from
Nov 8, 2024
Merged

[PHPUnit 10] Skip with Magic __get() on AssertIssetToAssertObjectHasPropertyRector #403

merged 3 commits into from
Nov 8, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 8, 2024 •
edited
Loading

with magic __get() property doesn't need to exists to be called.

see https://3v4l.org/3Pckj

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 38bdce4 into main Nov 8, 2024
6 checks passed
@samsonasik samsonasik deleted the skip-with-magic-get branch November 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik