[DeadCode] Add fixture to remove already known more specific type (#6309

)

* [DeadCode] Add fixture to remove already known more specific type

* Remove more specific property type

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Fixture/remove_specific_typed_property.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeConstantFloatType;
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeMoreSpecificObject;
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeObject;
+
+final class RemoveSpecificTypedProperty
+{
+    /**
+     * @var SomeObject
+     */
+    public SomeMoreSpecificObject $name;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeConstantFloatType;
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeMoreSpecificObject;
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeObject;
+
+final class RemoveSpecificTypedProperty
+{
+    public SomeMoreSpecificObject $name;
+}
+
+?>

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Fixture/skip_different_typed_property.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\DifferentTypeProperty;
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeMoreSpecificObject;
+
+final class SkipDifferentTypedProperty
+{
+    /**
+     * @var DifferentTypeProperty
+     */
+    public SomeMoreSpecificObject $name;
+}

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Fixture/skip_more_specific_type_in_docblock.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\DifferentTypeProperty;
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeMoreSpecificObject;
+use Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source\SomeObject;
+
+final class SkipMoreSpecificTypeInDocblock
+{
+    /**
+     * @var SomeMoreSpecificObject
+     */
+    public SomeObject $name;
+}

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Source/DifferentTypeProperty.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source;
+
+final class DifferentTypeProperty
+{
+
+}

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Source/SomeMoreSpecificObject.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source;
+
+final class SomeMoreSpecificObject extends SomeObject
+{
+
+}

rules-tests/DeadCode/Rector/Property/RemoveUselessVarTagRector/Source/SomeObject.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUselessVarTagRector\Source;
+
+class SomeObject
+{
+
+}

rules/DeadCode/PhpDoc/DeadVarTagValueNodeAnalyzer.php

@@ -7,6 +7,7 @@
 use PhpParser\Node\Stmt\Property;
 use PHPStan\PhpDocParser\Ast\PhpDoc\VarTagValueNode;
 use PHPStan\Type\IntersectionType;
+use PHPStan\Type\ObjectType;
 use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\UnionType;
 use Rector\NodeTypeResolver\TypeComparator\TypeComparator;
@@ -38,6 +39,12 @@ public function isDead(VarTagValueNode $varTagValueNode, Property $property): bo
             return ! $docType instanceof IntersectionType;
         }
 
+        if ($propertyType instanceof ObjectType && $docType instanceof ObjectType) {
+            // more specific type is already in the property
+            return $docType->isSuperTypeOf($propertyType)
+                ->yes();
+        }
+
         if ($this->typeComparator->arePhpParserAndPhpStanPhpDocTypesEqual(
             $property->type,
             $varTagValueNode->type,